exometer_core
exometer_core copied to clipboard
`exometer_report` gen_server doesn't restart reporters after restarting by supervisor.
exometer_report may be terminated by some reason and it also terminates all reporters.
Should they be restarted together with exometer_report gen_server?
For example, exometer_report gen_server may be crashed here during reporting function metric if my function callback does something like throw(timeout)
PR #74 refers to this problem.
@uwiger good! What do you think about that https://github.com/Feuerlabs/exometer_core/blob/master/src/exometer_function.erl#L232 only catches error class exceptions? It may be reason of reaching max restarts.
Well ... I guess it wouldn't hurt to also catch other categories, even though the likelihood of get_value() raising other exceptions should be very low. :)
I've seen this too. Maybe issue https://github.com/Feuerlabs/exometer_core/issues/36 is also related?