exometer_core icon indicating copy to clipboard operation
exometer_core copied to clipboard

`exometer_report` gen_server doesn't restart reporters after restarting by supervisor.

Open surik opened this issue 9 years ago • 5 comments

exometer_report may be terminated by some reason and it also terminates all reporters. Should they be restarted together with exometer_report gen_server?

surik avatar Sep 27 '16 12:09 surik

For example, exometer_report gen_server may be crashed here during reporting function metric if my function callback does something like throw(timeout)

surik avatar Sep 27 '16 13:09 surik

PR #74 refers to this problem.

uwiger avatar Sep 27 '16 16:09 uwiger

@uwiger good! What do you think about that https://github.com/Feuerlabs/exometer_core/blob/master/src/exometer_function.erl#L232 only catches error class exceptions? It may be reason of reaching max restarts.

surik avatar Sep 27 '16 17:09 surik

Well ... I guess it wouldn't hurt to also catch other categories, even though the likelihood of get_value() raising other exceptions should be very low. :)

uwiger avatar Sep 27 '16 18:09 uwiger

I've seen this too. Maybe issue https://github.com/Feuerlabs/exometer_core/issues/36 is also related?

beano avatar Sep 28 '16 19:09 beano