app icon indicating copy to clipboard operation
app copied to clipboard

iOS webpage crash on huge fallback list (1000+ songs)

Open FreTimmerman opened this issue 5 years ago • 5 comments

i'm currently testing Festify, and i have added a huge spotify playlist as fallback (1127 songs) this works okay on Desktop (Chrome) and Android browsers. But on iOS this gives issues: everytime you or someone else votes on a song, the page crashes. (actually: everytime the page reloads: so if a song is finished and the next one starts: also page crash) not for the playback device, but for visitor-devices!

the webpage will crash, and safari will try to reload it, but after a couple of times, safari will say "a problem repeatedly occurred on [festify_url] " smaller playlists work fine on my iOS device

the mentioned iOS device is an iPhoneX: Mozilla/5.0 (iPhone; CPU iPhone OS 11_4_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.0 Mobile/15E148 Safari/604.1

FreTimmerman avatar Sep 10 '18 21:09 FreTimmerman

Yeah, its just too much to display. We need paging for queues lists like these...

NeoLegends avatar Sep 11 '18 12:09 NeoLegends

Or we need to virtualize the queue better. In the meantime, maybe we could limit the visible fallback tracks to 20 or 50 because you don't need to see the whole fallback playlist anyway :p

leolabs avatar Sep 11 '18 12:09 leolabs

Yeah, I don't want to implement pages in the classical way either. Keep the infinite-scrollable list, but load the tracks as needed. We could try going back to iron-list, we'd just lose the FLIP animations.

NeoLegends avatar Sep 11 '18 12:09 NeoLegends

to be fair, i now realise 1000+ songs is kinda overkill anyway. that's over 70 hours of continuous music, not to mention extra songs other people will add. about 400 songs is 24+ hours, so that's plenty enough for most applications, i'd think? (i guess you can go 10 seconds without music in order to select another playlist even if it ends before your event does :p )

so maybe for now add a warning that huge playlists can have detrimental effects on user experience? until this issue is fixed properly...

FreTimmerman avatar Sep 11 '18 21:09 FreTimmerman

Yeah 1000 tracks is a lot, but since the data layer of Festify can handle that many tracks easily, the UI should be able to do the same. :)

NeoLegends avatar Sep 11 '18 22:09 NeoLegends