Austin S. Hemmelgarn

Results 395 comments of Austin S. Hemmelgarn

> Hello @Ferroin , > > Some collectors still do not have proper permission in DEB package: > > ```shell > -rwxr-xr-x 1 root netdata 21787 Nov 18 02:52 /usr/libexec/netdata/plugins.d/charts.d.plugin...

> > This ensures that behavior will remain consistent after the initial install. > > Which behavior? If the user installs with CMAKE_BUILD_TYPE set in the environment to something other...

Rebased to resolve merge conflicts and pick up latest changes.

Rebased again to pick up latest changes in master.

Rebased to pick up latest changes in master.

> > This is a known tradeoff taken based on discussion with the frontend team. Actually recursively listing all the files while still making CMake’s install directives work correctly is...

> The cleanup now works as intended and handles all filenames safely. Handles all current filenames. There’s a _reason_ this was using null terminated records instead of newline terminated records,...

Oh the irony, Copilot pointing out exactly what I was as I was writing my comment...

Force pushed to fix the code _properly_ without wasting resources and correctly accounting for the fact that a newline is actually a valid character in filenames on most UNIX-like systems.

I would propose 2026-06-30 as the end date for this because that coincides with the EOL date (and thus our end of support date) for Amazon Linux 2, which is...