FerriteViz.jl icon indicating copy to clipboard operation
FerriteViz.jl copied to clipboard

Ferrite 1.0 compat

Open termi-official opened this issue 1 year ago • 4 comments

In this branch and PR I develop the preparation for the upcoming Ferrite release.

TODOs

  • [x] Replace transfer_quadrature_face_to_cell with the Ferrite internal one
  • [x] Remove getgrid

Post-Merge

  • [ ] Enable reverse CI https://github.com/Ferrite-FEM/Ferrite.jl/blob/ffab3f0c64707d0dd5439ab1dc94c3b0927a76b2/.github/workflows/Downstream.yml#L29

termi-official avatar Oct 14 '23 00:10 termi-official

We need to add https://github.com/JuliaDocs/Documenter.jl/issues/2211

termi-official avatar Feb 09 '24 18:02 termi-official

Found today that elementinfo(::Interpolation) is broken on this branch.

KnutAM avatar Mar 22 '24 10:03 KnutAM

Reminder for myself - There is some kind of regression in the Makie API behavior which I need to investigate. MWE:

using FerriteViz.Makie, WGLMakie, Bonito

Page()

struct MakiePlotter{dim}
end

@recipe(MyLines) do scene
    Attributes(
        plotnodes=true,
    )
end


function Makie.plot!(WF::MyLines{<:Tuple{<:MakiePlotter{dim}}}) where dim
    plotter = WF[1][]
    if dim == 2
        lines = [Point2f(0.0,0.0)]
    else
        lines = [Point3f(1.0,1.0,0.0), Point3f(0.0,0.0,1.0)]
        @info "Peekaboo"
    end
    Makie.scatter!(WF, lines)
end

mylines(MakiePlotter{2}())  # 2D
mylines(MakiePlotter{3}())  # 2D
scatter([Point2f(0.0,0.0)]) # 2D
scatter([Point3f(1.0,1.0,0.0), Point3f(0.0,0.0,1.0)]) # 3D

termi-official avatar Jun 03 '24 12:06 termi-official

There is some issue regarding the depth with the interactivity. Other than that good from my side. @koehlerson if you agree with the changes we can merge and bump.

termi-official avatar Sep 30 '24 18:09 termi-official

There is some issue regarding the depth with the interactivity. Other than that good from my side. @koehlerson if you agree with the changes we can merge and bump.

Anything in particular? Will look into that this week

koehlerson avatar Oct 30 '24 11:10 koehlerson

There is some issue regarding the depth with the interactivity. Other than that good from my side. @koehlerson if you agree with the changes we can merge and bump.

Anything in particular? Will look into that this week

CI changes and some changes in utils.jl (e.g. I removed ε as it caused issues). Everything else should be a very mechanistic update.

termi-official avatar Nov 02 '24 22:11 termi-official

elementinf

Okay I need to fix this first.

termi-official avatar Nov 04 '24 17:11 termi-official

while checking if everything interactive works, I stumbled across this problem: https://github.com/Ferrite-FEM/FerriteViz.jl/issues/131

koehlerson avatar Nov 07 '24 13:11 koehlerson

The wireframe recipe breaks precompilation on this branch with Makie 0.21. :sweat:

termi-official avatar Jan 06 '25 17:01 termi-official