Ferrite.jl
Ferrite.jl copied to clipboard
Remove onboundary from examples
If removed from Neumann example, probably good to remove from examples as well? Ref #473
Edit: Also adopted an unrelated doc change from @fredrikekre's comment in #470
Codecov Report
Merging #474 (c60b89e) into master (b9998a0) will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 91.35% 91.32% -0.03%
==========================================
Files 22 22
Lines 3411 3411
==========================================
- Hits 3116 3115 -1
- Misses 295 296 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/iterators.jl | 95.38% <0.00%> (-1.54%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Move the face integration outside the cell loop and do:
for (cellid, faceid) in union(getfaceset(grid, "left"), getfaceset(grid, "right") )
is my prefered way :)
I like that better too, and it is what would be done by the BoundaryFaceIterator that is under construction!
Handled in #495