gamemode icon indicating copy to clipboard operation
gamemode copied to clipboard

Showing the requesting executable in the Dbus message

Open mihawk90 opened this issue 3 years ago • 0 comments

Hey there,

this is more of a feature request (-ish) then a bug report, so a short background for it: Sometimes games (especially running under wine) don't quit properly so the process that gamemode is watching remains running or keeps around as a zombie process, resulting in gamemode not disengaging. Personally I usually only notice this when my PC doesn't go to sleep, and in those cases I tend to just check the power management in KDE's system tray: image This is nice as it at least shows me that power management is indeed working, but suppressed. But especially when multiple games were run with gamemode it can get difficult to know which one is keeping it active when only realising this after some time.

It would be nice if this widget could also show the process that originally engaged gamemode, to make it easier to find the right one.

From searching through the repository it seems this message is set here: https://github.com/FeralInteractive/gamemode/blob/632f4650b49563e25d1bea44388543ff708d6595/daemon/gamemode-dbus.c#L738-L747

Would it be possible to include the executable passed to gamemode here? For example gamemoderun /usr/bin/something would show GameMode Activated (/usr/bin/something). When called directly from within the process (e.g. the games listed in the readme), it could just show the process-name. In either case it could also show the PID as a bonus. In case it was requested using the -r option it could just show the process ID instead.

As a sidenote: This same information would also be helpful when using gamemoded -s.

mihawk90 avatar Nov 24 '20 15:11 mihawk90