CausalDiscoveryToolbox icon indicating copy to clipboard operation
CausalDiscoveryToolbox copied to clipboard
verified publisher icon FenTechSolutions

GIES: intervention targets

Open bvarici opened this issue 4 years ago • 2 comments

I may be missing something but I think GIES algorithm may not work properly. It takes a “score” input, that has “targets” in pcalg R implementation, i.e., intervened nodes.

Only difference between GES and GIES implementation in this package seems to be the “score”, obs and int, as it should be. However, https://github.com/FenTechSolutions/CausalDiscoveryToolbox/blob/master/cdt/causality/graph/GIES.py doesn’t seem to have “target” for 'int' score. Could you elaborate whether something is missing in GIES implementation, or I am missing something. Thanks.

bvarici avatar Apr 07 '21 18:04 bvarici

Hello @bvarici, thanks for noting this point, I'll be fixing ths in the next release !

diviyank avatar Apr 19 '21 07:04 diviyank

Hi Diviyan, was this fixed? I don't think so, but I might be missing something.

Have a good day!

manonromain avatar Jun 15 '21 13:06 manonromain