CausalDiscoveryToolbox icon indicating copy to clipboard operation
CausalDiscoveryToolbox copied to clipboard

SID_CPDAG does not automatically converts a DAG to CPDAG

Open xwshen51 opened this issue 4 years ago • 1 comments

In cdt.metrics.SID_CPDAG, the prediction is not converted to a CPDAG. Currently one needs to convert a DAG to a CPDAG before inputting it to the function.

It may be better to add predictions = get_CPDAG(predictions) as done in SHD_CPDAG.

Thanks for your great contribution!

xwshen51 avatar Aug 27 '21 05:08 xwshen51

Hello ! Whoops ! Yes we should do this step before, thanks for the feedback !

diviyank avatar Nov 12 '21 08:11 diviyank