Femto-Emacs icon indicating copy to clipboard operation
Femto-Emacs copied to clipboard

Make femtolisp a submodule

Open chigoncalves opened this issue 7 years ago • 4 comments

It makes sense to have JeffBezanson/femtolisp as a submodule of FemtoEmacs, since it is a third party project, it makes lot easier to integrate upstream changes into FemtoEmacs, I suggest incorparate the current changes made to FemtoEmacs/femtolisp into your own fork of JeffBezanson/femtolisp, and then have it as the submodule of FemtoEmacs.

I suggest this approach:

  • Create a new branch in FemtoEmacs/femtolisp, this branch can be named femtoo-emacs for instance.
  • Incorporate current changes from FemtoEmacs/femtolisp into the branch.
  • Delete FemtoEmacs/femtolisp and then add your own fork as a FemtoEmacs submodule.

Chi

chigoncalves avatar Sep 15 '16 07:09 chigoncalves

I agree. I would like to get rid of this altogther and have the makefile pull the femtolisp code direct from Jeff repository and ensure any of our changes were put into seperate files etc. Then have a make target called femtolisp which grabbed, built it and applied our changes. I'm not that familiar with our changes to femtolisp as lucas did the work here. But I am going to go through them in detail at some point.

Also would like any changes / improvements we have made to femtolisp to be be a pull request to Jeff's codebase. Eg the maths code needs to go into its own math.c file and push to femtolisp.

BTW I will invite you to the FemtoEmacsDevs chat room on gitter. Hugh

hughbarney avatar Sep 15 '16 21:09 hughbarney

I would like to get rid of this altogther and have the makefile pull the femtolisp code direct from Jeff repository and ensure any of our changes were put into seperate files etc.

I would recommend keeping your own fork of Jeff's repository, cases where Jeff's refuses to merge changes from your fork.

I'm already trying to "merge" addins from Femto-Emacs/femtolisp to my fork of femtolisp.

Chi

chigoncalves avatar Sep 28 '16 16:09 chigoncalves

https://github.com/lambdaconservatory/femtolisp is soliciting patches from FemtoLisp users. I'm happy to give write access to anyone who wants it.

lassik avatar May 22 '21 08:05 lassik

Update:

I now manage the Femto repository at: https://github.com/hughbarney/femto/blob/master/README.md

I will take future updates on that repository.

I abandonned using FemtoLisp and use a tinyLisp implementation that is part of the actual codebase. The code was public domain and I was free to incorporate it fully into Femto. I also extended the TinyLisp to support strings. The result is very effective and stable. Plus we dont have to compile 12K of FemtoLisp with 2K of Editor code lines.

hughbarney avatar Oct 29 '23 17:10 hughbarney