Mikhail f. Shiryaev

Results 366 comments of Mikhail f. Shiryaev

@maxknv please, review my changes https://github.com/ClickHouse/ClickHouse/pull/61473/files/c75118c78d52c4e4cf27c213320d049eba049177..758acb433d577e548b2125ee4051996666766df7

yes, my fixes work https://s3.amazonaws.com/clickhouse-test-reports/61473/758acb433d577e548b2125ee4051996666766df7/bugfix_validation.html I'll move them to a dedicated PR

Here's the difference for running `did --width=0 --since=2024-03-19 --until=2024-03-25 --format=markdown | grep -v private` on the version 0.21 and from the branch: ```diff --- /tmp/did-0.21.md 2024-03-26 23:20:08.714955329 +0100 +++ /tmp/did-felixoid.md...

The tests fail with ``` :: [ 23:23:02 ] :: [ BEGIN ] :: Running 'did --test last quarter' [ERROR] GitHub API rate limit exceeded. Consider creating an access token....

Hello, dear @psss. I've spent some additional time researching whether it's possible to add an argument like `--github-approximate` easily. I'm not sure if it's even a way to go, so...

Dear @psss, is there anything I can do to have a kick-start here?

The last commit fixes the next issue ``` > did --width=0 --since=2024-05-14 --until=2024-05-27 --format=markdown --GitHub-issues-commented Status report for given date range (2024-05-14 to 2024-05-27) ============================================================= ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Mikhail f. Shiryaev Mikhail...

No problem, will do both! Glad you're back

> * What about implementing the `approximate-commented` as a config option rather than the command line? Should it be enabled or disabled by default? I'd disable it by default, but...

The problem was the guaranteed out-of-requests issue. Maybe with a new approach it will be reliable