BInwei Yang comments

Results 167 comments of


                                            BInwei Yang

Erase the previous processed WindowPartition in RowStreamingWindowBuild

> @xiaoxmeng Can you help to merge this PR? Thanks. Hold on please. I haven't verified.

Erase the previous processed WindowPartition in RowStreamingWindowBuild

@aditi-pandit can you take a look again? It's an important fix for common OOM issue from customer side. @xiaoxmeng can you review?

Erase the previous processed WindowPartition in RowStreamingWindowBuild

> @aditi-pandit @FelixYBW Resolved all your comments. Can you help to review again? Thanks. I updated the pool capacity from 8MB to 4MB [here ](https://github.com/facebookincubator/velox/pull/11077/files#diff-9f41a5e1a8da742fc53f54ba85588678cdb81ffb05b38eefebe21ad5138def8eR183)and the oom will occur without...

Erase the previous processed WindowPartition in RowStreamingWindowBuild

@aditi-pandit Any more comments?

Erase the previous processed WindowPartition in RowStreamingWindowBuild

The current PR can't fix the window OOM issue any more. Let me check.

[DOC] build arrow first when build Velox separately.

What's the script when you build Velox? Did you apply Gluten's velox patch when you build velox?

[VL] Support file cache spill in Gluten

@zhli1142015

[VL] the key in unnest Operator only support field

error becomes: ``` Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:1305 function:validate, thrown from file:ExprCompiler.cpp line:467 function:compileRewrittenExpression, reason:Scalar function map not registered with arguments: (INTEGER, BIGINT, INTEGER, BIGINT, INTEGER,...

[VL] the key in unnest Operator only support field

fixed

Fix Sort and Spill std::vector for rows memory not tracked causing OOM

> Can you help to check if this Pr can solve your problem? I change the reserve memoy value from fixed value 1GB to estimated maximum value considering std::vector and...