SketchyBar icon indicating copy to clipboard operation
SketchyBar copied to clipboard

[feature request] vertical bar

Open shaunsingh opened this issue 1 year ago • 1 comments

Is it possible to add an option to display the bar vertically on the left or right hand side? elements in the bar would go top to bottom instead of left to right

shaunsingh avatar Aug 29 '22 22:08 shaunsingh

Yes, I could imagine having such options. Popups already draw their items from top to bottom, so the general logic for such a bar is already contained. I would need to do some refactoring of the code while implementing this. I will experiment with this on a secondary branch once I have some free time.

FelixKratz avatar Aug 30 '22 06:08 FelixKratz

I did some experimenting with left and right positions of the bar. There are many things that are not working currently (groups, popups, shadows, ...) and this will remain an undocumented and experimental feature till it is fully baked. I am posting the experimental version of this feature to discuss a way forward with this.

Nothing of this changes anything about top/bottom bars, which is why I have decided to include it on master.

The width, left and right nomenclature in item configuration is not intuitive for left/right bars, at least not in the way that I have reused them currently.

The way I have designed it for now works the following for left/right bars:

  • icon and label of an item are still placed horizontally aligned
  • background paddings act vertically (despite being called left and right padding)
  • item width acts vertically (i.e. width means height)
  • the bar height property determines the width of the bar
  • y_offset is the margin of the bar
  • margin is the x_offset of the bar

All of this is super unintuitive and I am not happy with it. I could overload right with top and left with bottom as well as x_offset and margin to make it a bit better. Those could then be used synonymously in all configurations (e.g. padding_left is equivalent to padding_top).

If there are opinions on how to do this in an intuitive and simple way, I would enjoy to discuss them here.

Demo: Screen Shot 2022-10-06 at 21 17 49

config: sketchybar_vertical.zip

FelixKratz avatar Oct 06 '22 19:10 FelixKratz

Looks wonderful! Personally I don't use any shadows and popups so this will work just fine for me. aliasing right/left with top/bottom would definitely be a nice QOL improvement but not a big issue or anything. Thank you for the awesome project once again <3

shaunsingh avatar Oct 06 '22 23:10 shaunsingh

I will play with this some more and polish, document and properly test it some time in the future. I will close this for now since it is contained as an experimental feature in the latest release.

FelixKratz avatar Oct 12 '22 09:10 FelixKratz