FelixKratz
add nix-darwin package
Hey, I wrote a simple package for easier use with nix-darwin, because I found a lot of people having issues while trying to use it in nix-darwin. I have also tested it on my own nix-darwin system and it is working flawlessly
Looks good in theory, I don't have nix-darwin to test it with if someone else can confirm I'd say its probably okay to merge assuming Felix is happy with having it packaged into Nix
With just a quick glance at that it seems probably fine; I should be able to find the time tomorrow to give it a proper look/test.
With just a quick glance at that it seems probably fine; I should be able to find the time tomorrow to give it a proper look/test.
Ok
Yeah sorry it's been a busy week. There are a few more changes I'd like to make; do you think you can select on the PR to allow maintainers to commit on your code?
Apparently I'm not a maintainer. So either I'm going to need to be promoted to one, or I'm going to need you to provide me (temporarily) with push access to your "nix-darwin-package" branch in your repository.
(I did have a few changes I made)
@FelixKratz I feel that me and @amusingimpala75 have done a good job and I don't see anything wrong with the PR? @amusingimpala75 your thoughts?
I am no expert with nix, but usually the distribution of a package occurs through a different repo than the one hosting the code, or am I mistaken? At least for sketchybar there is a nix formula in an official nix repo (which I myself am not maintaining).
Nix can be used for packaging both in-tree (flake.nix etc. in the project's repo) as well as separately distributed (as in the nixpkgs repo). An example of both is Ghostty, which has a flake for packaging from source as well has a version in nixpkgs. Seeing as this is a relatively niche project that has no versioning and is intended to be built from source, I think it would make sense to package it within the project. It doesn't do any pinning of versions in repo, so if a user wanted to update to a later commit they would just update their personal pin (nix flake update in their dotfiles repo) without you needing to bump anything in this repo.
It can also just be (fairly easily) manually packaged in the user's dotfiles repo, but doing it this way removes the user having to figure out how packaging with Nix works.
If people start using it here and it's working we can add it to nixpkgs-unstable
@amusingimpala75 How about we file a package request in the nixpkgs repository?
I currently have an open PR in the nixpkgs repo; I may need to ping someone to get it reviewed.
