Felienne Hermans

Results 332 comments of Felienne Hermans

Nice idea, but we now have it as it is and we are used to it :)

Info from @alaaeddin-swidan: I had different thoughts on how to check this, but eventually settled into checking the Syrian music school books, because Syrians are known to be very strict...

> I happen to have seen a reddit post about this last week (https://www.reddit.com/r/MapPorn/comments/18zihpx/what_each_european_country_calls_the_musical_note/). Might not be the best source of info, but it does imply that most European countries...

It would be great if you can pick this up @bobidle! A kewyord per note seems a good approach, or maybe we need two, "A" and "do"? It seems people...

> > Maybe we can make some tags, instead of letting the teachers create their own tags, because at the moment their are a lot of nonsense tags. This defeats...

Alternatively, we can make a propose-approve system but I think the cleanup absolutely needs to happen first!

> There are many tags named after keywords: > > ![image](https://private-user-images.githubusercontent.com/20051470/346576286-21536fbf-e43f-4569-8b3d-afb165128baf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MzQ4NjYsIm5iZiI6MTcyMDUzNDU2NiwicGF0aCI6Ii8yMDA1MTQ3MC8zNDY1NzYyODYtMjE1MzZmYmYtZTQzZi00NTY5LThiM2QtYWZiMTY1MTI4YmFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDE0MTYwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc4NGVmNWE5NmI3YzFhZmZkMzgzN2U0YTU4YTAyZmU0NmYyNjNlM2E5NTJkMjE2MjE5M2VhNDFmYzkxYTQ4NGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ACznHISEjAXneIB6lG4iaRtviTN0TY5NaxH45Y5-T9Q) > > What should we do about them? I'm now removing tags that make no sense or are only...

> Just noticed the attached PR. Will take a look at it. So far this issue is a nice way of introducing myself to the code base. Taking my (somewhat...

Hi @jpelay and @ToniSkulj! I have updates all level tests, except for one that I did not know how to deal with (I commented that out in https://github.com/hedyorg/hedy/pull/5117/commits/0061806df62fa378fc10c7b86b416f6efb7920eb) I am...

> Hi @Felienne! Thank you for adding the tests! I fixed the level 8 test, all tests should be passing now. > > The only case that remains is when...