FedML icon indicating copy to clipboard operation
FedML copied to clipboard

terminology in run_vfl_fc_two_party_lending_club.py

Open peiji1981 opened this issue 5 years ago • 7 comments

hello, i may find a mistake in run_vfl_fc_two_party_lending_club.py . only party_a has label , so party_a may be host not guest ?

peiji1981 avatar Nov 06 '20 10:11 peiji1981

@yankang18 Hi Yan Kang, please help to check whether this is an error.

chaoyanghe avatar Nov 06 '20 20:11 chaoyanghe

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model.

The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model. The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

yankang18 avatar Nov 09 '20 03:11 yankang18

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model.

The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model. The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

Thx, buddy . But this setting may be confused. Generally, the host has label

peiji1981 avatar Nov 09 '20 03:11 peiji1981

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model. The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model. The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

Thx, buddy . But this setting may be confused. Generally, the host has label

So the code is correct. It doesn't matter how to call one of the parties.

chaoyanghe avatar Nov 09 '20 03:11 chaoyanghe

@peiji1981

Different scenarios may use different terminology. To avoid confusion, we may use a more neutral name for the host and guest.

yankang18 avatar Nov 09 '20 04:11 yankang18

@yankang18 how about drawing a diagram to illustrate our current implementation?

chaoyanghe avatar Nov 09 '20 04:11 chaoyanghe

@yankang18 how about drawing a diagram to illustrate our current implementation?

hello, Dr.He, can you share a link for download the lendingclub dataset , the previous link did not conclude the data

peiji1981 avatar Nov 16 '20 07:11 peiji1981

Closing this issue, since it is not related to a problem of the FedML library but rather to how to tackle a vertical federated learning setting.

fedml-dimitris avatar Oct 24 '23 18:10 fedml-dimitris