FedML icon indicating copy to clipboard operation
FedML copied to clipboard

FedML-AI Docstrings Update

Open rajveer43 opened this issue 2 years ago • 7 comments

close #1259

Add doc strings for the python methods. and code update

I will add docstrings to every file in the repo. please do not merge it now.

@fedml-alex would you please approve the workflows

python\fedml\fa\aggregator\avg_aggregator.py

rajveer43 avatar Sep 01 '23 07:09 rajveer43

Could you fix merge conflicts please?

alaydshah avatar Sep 28 '23 22:09 alaydshah

Could you fix merge conflicts please?

Sure I am trying to solve it ASAP.

rajveer43 avatar Sep 29 '23 02:09 rajveer43

Could you fix merge conflicts please?

Sure I am trying to solve it ASAP.

Actually, while you're at it, could you instead split the PR's per module? Would give us more velocity to review that way

image

alaydshah avatar Sep 29 '23 04:09 alaydshah

I was thinking of it. at the start of this week.

Could you fix merge conflicts please?

Sure I am trying to solve it ASAP.

Actually, while you're at it, could you instead split the PR's per module? Would give us more velocity to review that way

image

rajveer43 avatar Sep 29 '23 04:09 rajveer43

@alaydshah the conflicts are not visible in the local text editor. what should I do?

rajveer43 avatar Sep 29 '23 04:09 rajveer43

@alaydshah I have solved the conflicts. kindly have a look

rajveer43 avatar Sep 30 '23 08:09 rajveer43

@rajveer43 can you please check if this PR works on dev and checkout from there?

fedml-dimitris avatar Oct 21 '23 21:10 fedml-dimitris