Fabian Keßler

Results 147 comments of Fabian Keßler

@xournalpp/core, this is ready for review. I also had to bump the Linux and mac versions, since ubuntu20.04 only ships gcc10, and we require at least 11. The current version...

> Ok, I will try to compile it on my MacBook Pro (from mid 2014) on BigSur. It is too old to install Ventura (or even Monterey), so it may...

> There are a whole bunch of new warnings. It would be great if you could fix them. Here is the build log on Apple M2 > Build log Which...

> It was now easy to compile and run it on my M2. Haven't checked yet if everything works as it should. Is there something I should look at closely?...

I am not sure, if I should fix deprecation warnings. I would do those over time in several other PR's: u8path -> currently no sane way to fix them. Occurrences...

>Now when running I got an error this time: > > /Users/roland/.config/xournalpp/settings.xml:9: parser error : Input is not proper UTF-8, indicate encoding ! >Bytes: 0xFB 0xC7 0xB4 0x67 >

> > > Now when running I got an error this time: > > > /Users/roland/.config/xournalpp/settings.xml:9: parser error : Input is not proper UTF-8, indicate encoding ! > > >...

Oh, that's UB, since u8string is a temporary, lost after that line. Good catch.

@rolandlo it should work now. I also found another occurrence of a dangling reference to an u8string.

> Silence the warning with something like _SILENCE_CXX20_U8PATH_DEPRECATION_WARNING but I can't tell if that's compiler independent No, this is MSVC-STL only, but I opened a ticket at gcc's issue tracker:...