docsmith icon indicating copy to clipboard operation
docsmith copied to clipboard

Published 20 hours ago • verified publisher icon Fdawgs

feat(routes): add html-to-pdf route

Open NHS-juju opened this issue 2 years ago • 3 comments

Known issues: html-to-pdf plugin lacks proper input validation, so currently will render anything a browser would attempt to render and prints this to a PDF file. In turn, the testing suites for this plugin are lacking in quality compared to the overall project.

NHS-juju avatar Apr 28 '23 08:04 NHS-juju

@NHS-juju going to take a look at this as part of /HTML/* routes alongside https://github.com/Fdawgs/docsmith/issues/1469 😄

Fdawgs avatar May 12 '23 07:05 Fdawgs

@NHS-juju could you enable Allow edits from maintainers on this PR, please? I'll sort all the merge conflicts and tests for this.

Fdawgs avatar May 18 '23 17:05 Fdawgs

@Fdawgs I can't see that option, and the page you linked suggests it is because the fork is from an Organisation account and the feature is only available when the fork is owned by a personal account 😐

I attempted to resolve the conflicts via the browser, and now merging is blocked... my bad!

NHS-juju avatar May 18 '23 19:05 NHS-juju