Chris West

Results 19 comments of Chris West

I'm guessing that wasn't the right `valgrind` command. However, I don't think: valgrind --tool=callgrind --callgrind-out-file=callgrind.txt target/release/hello ...is right either, as the output it prints is very different to the line...

Ah right. It's because my path has a number in. Lines like: Profiled target: /var/tmp/faux170317.0/hello/target/release/hello (PID 22911, part 1) ..match the insanity regex: \d+\s*[a-zA-Z]*$*_*:*/+\.*@*-*|\d+\s*[a-zA-Z]*$*_*\?+:*/*\.*-*@*-* ..due to a lack of any...

This is going to be non-idempotent, right? Is there a good way to document or warn people about that? I don't know of many other non-idempotent modules.

@ayosec: After review, I am not sufficiently confident in the code to publish it under my name, so not at this time, no.

The CI failures are about the use of inline `#[cfg..` in `1.9.0`, which I'm too lazy to remove at this stage; it passes fine on stable, beta and nightly, and...

I've been thinking about this. I don't think it can be done in a platform agnostic way (yet!). As such, I don't think exposing a new interface, which you have...

As of today's `HEAD`, it seems to panic instead, which is much worse: ``` % cargo run --example client https://fau.xxx/ Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs Running...

FYI our fork https://github.com/snyk/graphlib has many of the changes you're rolling out, including a complete TS port.

Excellent review of `Zeroize`. I have raised the [`capacity()` with them directly](https://github.com/iqlusioninc/crates/issues/178). For the `realloc` issue, I suspect a `Vec`-like type (with the zero-on-realloc) would work here? I also [raised...

Oh dear. I've already thought of more things to add. There are mathematical solutions to timing issues which can be implemented on top of the non-constant-time library as it currently...