aws-s3 icon indicating copy to clipboard operation
aws-s3 copied to clipboard

Added fetch with progress

Open luisgurmendez opened this issue 6 years ago • 14 comments

luisgurmendez avatar Dec 01 '18 13:12 luisgurmendez

This new implementation of fetch, changes the result data response. But adds functionality to allow progress bar

luisgurmendez avatar Dec 01 '18 13:12 luisgurmendez

Hi @luisgurmendez! Thanks for this PR. I'll be testing and then merge it!

Fausto95 avatar Dec 01 '18 18:12 Fausto95

We could maybe find a way to maintain the same response as fetch, so that the lib is compatible with earlier versions. Let me work on this a few days

luisgurmendez avatar Dec 01 '18 23:12 luisgurmendez

Will this progress bar help in uploading file ?

AliAdnanSohail avatar Dec 10 '18 14:12 AliAdnanSohail

@Fausto95 I'm waiting for this feature..

imakshath avatar Dec 21 '18 10:12 imakshath

Actually it doesn't work because you're not passing the callback function to the S3.uploadFile method! Could you fix this?

Fausto95 avatar Mar 16 '19 21:03 Fausto95

Hi, does this allow it possible to get progress on file upload to S3

afolabiabass avatar Mar 23 '19 23:03 afolabiabass

@Fausto95 my bad I forget to push, let me check it

luisgurmendez avatar Mar 24 '19 01:03 luisgurmendez

Thanks buddy, it looks like your branch still not up-to-date with master which now uses TypeScript instead of normal Javascript

Fausto95 avatar Mar 24 '19 18:03 Fausto95

@Fausto95 I've added typescript but it need to be tested I dont' have time right now :S maybe in a week or so

luisgurmendez avatar Mar 24 '19 20:03 luisgurmendez

Any chance this will be merged soon and released?

afolabiabass avatar May 09 '19 07:05 afolabiabass

Any change this can be merged?

tcollins590 avatar Nov 10 '19 16:11 tcollins590

another vote for this PR

swangy avatar Apr 04 '20 05:04 swangy

fyi anyone looking for this feature, i added the PR into a fork here https://github.com/swangy/aws-s3 if anyone would like to help improve this it'd be much appreciated.

swangy avatar Apr 14 '20 18:04 swangy