Tokyo-Night-GTK-Theme icon indicating copy to clipboard operation
Tokyo-Night-GTK-Theme copied to clipboard

Pink accent color way harsher than others

Open leaty opened this issue 10 months ago • 1 comments

This might (?) be intentional, however it's in some pretty drastic contrast with the other theme variants so it makes me believe this is wrong. Almost all text becomes straight up pink.

Now I don't know what the actual color should be (or if this is in fact intentional) but I winged up a color that works for me (dark only) $pink-dark: #ff8cc4;.

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-default.scss#L8-L9

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-storm.scss#L8-L9

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-moon.scss#L8-L9

Contrast seen below between pink-dark and purple-dark: image image

leaty avatar Mar 31 '24 19:03 leaty

This might (?) be intentional, however it's in some pretty drastic contrast with the other theme variants so it makes me believe this is wrong. Almost all text becomes straight up pink.

Now I don't know what the actual color should be (or if this is in fact intentional) but I winged up a color that works for me (dark only) $pink-dark: #ff8cc4;.

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-default.scss#L8-L9

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-storm.scss#L8-L9

https://github.com/Fausto-Korpsvart/Tokyo-Night-GTK-Theme/blob/58a04f1d4be7ee498ddaa31aa8bc5716f554aa0c/theme/src/sass/_color-palette-moon.scss#L8-L9

Contrast seen below between pink-dark and purple-dark: image image

Hello, @leaty Yes, I know what you mean, I'm working on fixing this and other small bugs to update as soon as possible. Thanks for the report.

Fausto-Korpsvart avatar Apr 01 '24 13:04 Fausto-Korpsvart