junit5-docker icon indicating copy to clipboard operation
junit5-docker copied to clipboard

Bug when i run tests in windows

Open zeroual opened this issue 9 years ago • 8 comments

capture

zeroual avatar Dec 14 '16 09:12 zeroual

I think its from our use of currentTimeMillis in our tests. The javadoc says :

Returns the current time in milliseconds. Note that while the unit of time of the return value is a millisecond, the granularity of the value depends on the underlying operating system and may be larger. For example, many operating systems measure time in units of tens of milliseconds.

We may have to find a way to tests that is more reliable… :/

FaustXVI avatar Dec 14 '16 10:12 FaustXVI

yeah , any way nobody use windows except me :joy:

zeroual avatar Dec 14 '16 11:12 zeroual

Does it happens every time ?

Xavier Detant

On 14 Dec 2016 12:01, "Abdellah ZEROUAL" [email protected] wrote:

yeah , any way nobody use windows except me 😂

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FaustXVI/junit5-docker/issues/64#issuecomment-267006037, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-EH3g3yy5t1wl7Yzn-bqVwPbw4IoYNks5rH8x2gaJpZM4LMuyl .

FaustXVI avatar Dec 14 '16 11:12 FaustXVI

@FaustXVI as a quick workaround, we could have it skipped when platform is windows ? :smiling_imp:

vdemeester avatar Dec 14 '16 11:12 vdemeester

@vdemeester or add a windows build on the CI ? :p

FaustXVI avatar Dec 14 '16 13:12 FaustXVI

@FaustXVI oh yeah :angel: we should setup appveyor for that :angel:

vdemeester avatar Dec 14 '16 13:12 vdemeester

Created #66 for that :)

FaustXVI avatar Dec 14 '16 13:12 FaustXVI

As explained in #66, we can't have a way to test on windows easily :( I'll remove the milestone for now.

FaustXVI avatar Dec 19 '16 16:12 FaustXVI