junit5-docker icon indicating copy to clipboard operation
junit5-docker copied to clipboard

What about private repositories with password?

Open FaustXVI opened this issue 9 years ago • 3 comments

FaustXVI avatar Dec 13 '16 23:12 FaustXVI

You mean private docker registry ?

vdemeester avatar Dec 14 '16 10:12 vdemeester

Yes sir !

FaustXVI avatar Dec 14 '16 10:12 FaustXVI

So… it shouldn't be a problem, it's not really our responsability :

  • private repository means the image has it in its name, something like example.com/my/cool/image
  • docker pull for example (or even docker-compose) does not ask for a password or something — you have to docker login before.

So, we should make sure docker-java support that (i.e. the $HOME/.docker/config.json) file and the credential part — but we shouldn't have any specific code for this use case in this library 👼.

vdemeester avatar Dec 14 '16 10:12 vdemeester