vite-plugin-image-optimizer icon indicating copy to clipboard operation
vite-plugin-image-optimizer copied to clipboard
verified publisher icon FatehAK

fix: add missing mkdir recursive option

Open hex-ci opened this issue 2 years ago • 1 comments

What is the purpose of this pull request?

  • [X] Bug fix
  • [ ] New Feature
  • [ ] Documentation
  • [ ] Other

Description

Fixed #27

There are two mkdir in the code, one of which uses recursive, and the other does not. Without recursive, multi-level directories cannot be created and an error will be reported.

Checks

  • [X] PR adheres to the code style of this project
  • [X] Related issues linked using fixes #number
  • [X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [X] Lint and build have passed locally by running pnpm lint && pnpm build
  • [X] Code changes have been verified in local
  • [X] Documentation added/updated if necessary

Additional Context

hex-ci avatar Aug 25 '23 08:08 hex-ci

Please merge !

julien-blanchon avatar Mar 26 '24 19:03 julien-blanchon

Yeah I see absolutely no problem in merging this, @FatehAK. For now I have made a fork which implements this PR at @jonasgeiler/vite-plugin-image-optimizer

jonasgeiler avatar May 26 '24 14:05 jonasgeiler

Thanks for the support @hex-ci and @jonasgeiler this change is now available in v1.1.8.

FatehAK avatar May 26 '24 16:05 FatehAK