fix(AutoGiftBox): added missing 5 star ember and update the counting of embers
Pull Request Type
- [ ] Chore
- [X] Bugfix
- [ ] Feature Implementation
- [ ] Documentation
- [ ] Other
Related issue
- closes #2109
Description
- added the missing 5 star ember to be able to fetch by the script
- change the counting from just gold embers only to also include silver embers, this enables to save time due to less time wasting clicking when we are already max amount of embers that you can fetch.
Screenshots
Testing
Additional context
Build 716
Download the latest APK for testing here
[!NOTE] You need a GitHub account to download the APK.
This URL is valid as long as the artifact has not expired yet.
It is selecting the 5 stars now, but not respecting the limiters
https://github.com/user-attachments/assets/ed1982cc-f976-4150-b846-ed62016791f6
Side note: Shouldn't the Regex be instantiated outside the loop? https://github.com/Fate-Grand-Automata/FGA/blob/dea551c01eb934344fecbb4952125b23a4d63dc3/scripts/src/main/java/io/github/fate_grand_automata/scripts/entrypoints/AutoGiftBox.kt#L158
It is selecting the 5 stars now, but not respecting the limiters
looks like the usual OCR problem, I'll adjust the detection region later when I'm on my laptop
Side note: Shouldn't the Regex be instantiated outside the loop?
oof, forgot to also update that here
btw, thanks for the feedback
edit:
gotten busy, going to be delayed.
Working like a charm 👍
https://github.com/user-attachments/assets/713ee875-e7e5-4472-957e-d76b1e6a4a96