FGA icon indicating copy to clipboard operation
FGA copied to clipboard

Add more checks for Support servant

Open Vylantze opened this issue 3 months ago • 4 comments

#2107

  • [x] Added a fallback for when Support fails to be detected
  • Add more support images (Failed, I was not able to make it work)

Support fallback

https://github.com/user-attachments/assets/9bb69cf2-506a-4daf-af79-81ed34d319b6

Vylantze avatar Sep 07 '25 11:09 Vylantze

Build 496

Download the latest APK for testing here

[!NOTE] You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

github-actions[bot] avatar Sep 07 '25 11:09 github-actions[bot]

Narrowed the support region. I have also attempted to add new support images, but to no avail (it didn't work for the case above).

New region
image

https://github.com/user-attachments/assets/85b41791-0bc6-4202-9587-52045eb23925

New support images (that have failed)
support_2 support_3

Vylantze avatar Sep 07 '25 16:09 Vylantze

I am aware that it could be a lot of work, but I think it can be done by splitting the support icon by letter and if a % (eg 60%) is matched then it's support, otherwise it's not.

muscularcandy67 avatar Sep 17 '25 19:09 muscularcandy67

I am aware that it could be a lot of work, but I think it can be done by splitting the support icon by letter and if a % (eg 60%) is matched then it's support, otherwise it's not.

The problem is that the less letters there are, the less unique the pattern becomes. With the images I already tried, it was already unable to distinguish between a normal card and a support card.

The problem is that I am not sure why these additional support images are not being detected when it appears unique enough to the human eye. The logic behind the detection and the relationship between the region and reference image are things I am completely unaware of after all.

Vylantze avatar Sep 17 '25 19:09 Vylantze