Fate-Grand-Automata
Support card was not matched, and Olga Marie and Koyanskaya of the Light are treated as the same Servant
Preparation
- [x] I tested the latest release
- [x] I looked at other issues (even the closed ones)
- [x] I read the Troubleshooting Guide
FGO server
JP
FGA build number
2993
Describe the bug
When using this setup, FGA fails to detect the difference between Olga Marie and Koyanskaya of the Light. Also, Koyanskaya of Light failed to be detected as as Support Servant in this scenario as well.
I have setup the situation in Android Studio, on master branch, and executed debug mode.
Sample screenshots for testing
Video
Unable to host the highest quality on Github, so putting a higher quality stream here: https://streamable.com/6xu1av
https://github.com/user-attachments/assets/6b942ded-1e66-4480-a9b4-ab6b0ed98e00
Device model
Samsung SM-G9750
Android version
12
Screen size
1920x1080
RAM
8GB
Okay, I think I know the cause.
This is the support image, and half the image is being blocked by the buffs on the Koyanskaya cards. More support image samples probably need to be added or this sample needs to be changed.
| Support image reference |
|---|
This is the super buff bug, can't be helped unless we can match it even with some parts are getting covered..
Current workaround is to have treat support servants as your own in the settings but maybe you can find a workaround with opencv/ML matching
I think I'll add an additional Support image to the list, so that multiple images can be used to determine whether it is a Support. Particularly, I'll add one additional one for the back half of Support PORT, which appears to be far enough away (since it is kinda outside the card).
But, additionally, I'll add a fallback check for the support servant for if it doesn't get detected by the support tag. It does mean always scanning the face cards (like in Treat support servants as your own), but I think it is better than completely failing to detect the support servant and having misdetection like now.
which appears to be far enough away (since it is kinda outside the card).
unfortunately it can also be covered. that's why this is annoying because if you gave too many buff/received too many buff icons it can't be detected.
I see. Then the additional fallback check will be even more useful then.
I'll make a pull request soon.