Pop up scroll window cannot select third option

[Taka499]

Preparation

• [x] I tested the latest release
• [x] I looked at other issues (even the closed ones)
• [x] I read the Troubleshooting Guide

FGO server

JP

FGA build number

2991

Describe the bug

For the example in the recording, I am unable to select the third "優先" option. It simply returned to the top of the scroll window when touched.

Video

https://github.com/user-attachments/assets/c897e469-8819-4f58-939a-ab23ac919a36

Device model

Xiaomi Redmi K20 Pro

Android version

10

Screen size

1080 x 2340

RAM

12GB

[Taka499]

Maybe this issue is as same as this issue 2092

[Vylantze]

I actually have this exact same problem on the phone I play FGO on too. It doesn't have this issue in the emulator.

Might just be phone model differences. The device I use is a Samsung S10+.

EDIT: Added a video as well. As you can see, it is actually impossible to click on the lower options because it jumps to the top after attempting to click.

https://github.com/user-attachments/assets/1acb0c33-642d-4707-880a-a956ce567a83

[Vylantze]

This appears to be a LazyColumn issue.

Doing this appears to be a workaround to the issue in my own device. However, it makes the scroll box really ugly in the android studio emulator. Also, it does not actually solve the original problem (since LazyColumn still resets the scroll state and scrolls back up).

I did try setting the content height manually, but even when it was perfect in the emulator, it looks too small on my S10+ (which is the same issue as the release build).

[ArthurKun21]

if you are going to fix this here's the answer

Just use AlertDialog with box and inside the box is the lazyColumn.

[Vylantze]

You seem to be more familiar with it, so I'll leave it to you. I don't mind testing after a build has been made.

[ArthurKun21]

lots of my PRs still aren't getting merged.

And this one is simple enough for bug fix practice if anyone wants to fix it

[Vylantze]

Sure. I'll take it up then, since I have a device to test it on.

[Vylantze]

It appears that this LazyColumn is already nested inside another set of structures which is finally already in a ThemeDialog. I am not familiar enough with the environment to figure it out just based on what you said, unfortunately.

I'll go back to my other task.

[Vylantze]

@Taka499 Try downloading https://github.com/Fate-Grand-Automata/FGA/pull/2104#issuecomment-3248000463 and see if your issue is fixed.

[Taka499]

@Vylantze Thank you for the fix! I just noticed the reply and found the link is already unavailable. Does the fix applied in the newest release?

[Vylantze]

@Taka499 Try downloading it again.

It is not available in the newest release because this fix is not the ideal fix. But, if it works, we can work towards something that is more appropriate.

[Taka499]

@Vylantze There's no more scrolling window on my device now.

[TryStranic]

Version from comment #2104 is not available anymore. Is it over, the fix won't be included in new versions?

[Vylantze]

@TryStranic The fix isn't a proper solution and some menus are still failing to be clicked on in the specific devices. I have rerun the build, so you can try downloading again.

If for some reason it no longer works, or the link is no longer valid, my recommendation is the following:

• Make a new setup from scratch. Most of the time, the default is what you want to change back to.
• Use an emulator/another device to edit the settings, export them and then re-import them into your main device.

PS: I will also additionally link it here as a release from my own repository (since I have no permissions to upload to this repository). For those worried, it should be reliable because I'm the one who made the patch for the pull request in the first place.

[reconman]

I've decided to merge the temporary fix for now