command spell

[ArthurKun21]

command spell

Pull Request Type

• [ ] Bugfix
• [X] Feature Implementation
• [ ] Documentation
• [ ] Other

Related issue

• fixes #1869
• fixes #2017

Description

Allows the usage of command spell. Features tracking of command spell and shows warning when used up to 3 times inside the script.

Screenshots

Main Screen

Command Spell Screen

---

Ran out of Command Spell

Main Screen

Command Spell Screen

---

In use

when ran out

when deleting the cs usage

Testing

Additional context

[ArthurKun21]

https://github.com/Fate-Grand-Automata/FGA/actions/runs/12008004876/artifacts/2232219355

[ArthurKun21]

https://github.com/Fate-Grand-Automata/FGA/actions/runs/12022628878/artifacts/2236490656

Fix the colors to make it more distinct from one another

[ArthurKun21]

https://github.com/Fate-Grand-Automata/FGA/actions/runs/12061386733/artifacts/2247635961

[ArthurKun21]

problems with ultrawide screens to open the command spell dialog

[ArthurKun21]

https://github.com/Fate-Grand-Automata/FGA/actions/runs/12463523025/artifacts/2355056461

[github-actions[bot]]

Build 335

Download the latest APK for testing here

[!NOTE] You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

[ArthurKun21]

Last time there was a problem with ultrawide screen so I implemented the possible fix bb3f48e59e1730606c38e6417afbab8b307f515e, but I received no further replies when I presented the fix to tester so I don't know the results. It should technically work though

[cy1366371760]

Hello, when will this be merged to main branch?

[ArthurKun21]

I don't know

[cy1366371760]

I don't know

Hi, I cloned this branch. It seemed that there are only JP and EN's command spell image. So I added a CN image and it worked smoothly. Thank you for the implementation! Here is the CN image, perhaps you can add it:

[ArthurKun21]

Hi, I cloned this branch. It seemed that there are only JP and EN's command spell image. So I added a CN image and it worked smoothly. Thank you for the implementation! Here is the CN image, perhaps you can add it:

can you also tell us your phone specs?

just wanna know if you are on wide/ultrawide screen and if it ever worked out for you. thanks!

[cy1366371760]

can you also tell us your phone specs?

just wanna know if you are on wide/ultrawide screen and if it ever worked out for you. thanks!

My phone screen is 2340 * 1080. I reshape the screenshot into 1560 * 720 and then crop.

[ArthurKun21]

https://github.com/Fate-Grand-Automata/FGA/blob/e8fc0fd53f3529825fc0887a3122c788c539de6c/scripts/src/main/java/io/github/fate_grand_automata/scripts/FgoGameAreaManager.kt#L65

oh we run things with 1280x720 size

[ArthurKun21]

I'm going to YOLO this one for you @cy1366371760

[cy1366371760]

I'm going to YOLO this one for you @cy1366371760

Thank you!

[ArthurKun21]

You access the alpha from here https://github.com/Fate-Grand-Automata/FGA/pull/1880#issuecomment-2574161541 it always get autoupdated with each new build from this PR

[cy1366371760]

You access the alpha from here #1880 (comment) it always get autoupdated with each new build from this PR

Hi, today I use adb command to adjust my phone's resolution to 1280 * 720 size, and remake the screenshot. It is still runnable in my phone, and I guess it will be more robust on other devices:

[ArthurKun21]

It is still runnable in my phone, and I guess it will be more robust on other devices:

I'm going to take your word for this and update the build with your latest template image.

[ArthurKun21]

I still think it is better to show the two options even if most people would only use the NP for command spell