FGA
FGA copied to clipboard
Fate-Grand-Automata
Localization: zh_CN
Fixed some typos(also in zh_TW) and added some localized texts in zh_CN.
Some features I never used were not tanslated: p_roll_limit and overlay_notification_text.
https://github.com/Fate-Grand-Automata/FGA/blob/35279ab7dbbbae2c91bc5f2b4c80a3ebff419c7e/app/src/main/java/com/mathewsachin/fategrandautomata/ui/exit/BattleExit.kt#L62-L63
and
https://github.com/Fate-Grand-Automata/FGA/blob/35279ab7dbbbae2c91bc5f2b4c80a3ebff419c7e/app/src/main/java/com/mathewsachin/fategrandautomata/ui/launcher/LotteryLauncher.kt#L70
I am not familiar with Kotlin, could you add those phrases into localized.xml ?
I found some hard-coding sentences:
https://github.com/Fate-Grand-Automata/FGA/blob/61cf9636cdd591c090850e3a1cf31db07bf60038/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/BattleGroup.kt#L101-L102
https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/AdvancedGroup.kt#L81
https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/prefs/src/main/java/com/mathewsachin/fategrandautomata/prefs/core/GameAreaMode.kt#L4-L7
https://github.com/Fate-Grand-Automata/FGA/blob/cd8f96085f0c5c81a1b3dc772f47bfb313592def/app/src/main/java/com/mathewsachin/fategrandautomata/ui/more/AdvancedGroup.kt#L108
I've added more translatable strings here https://github.com/Fate-Grand-Automata/FGA/commit/ea8ebf4305cbddc6761e3450e8d3d8ac233daf70#diff-2d207ac16b141c7910606683e804e844a24ef211c6210e4f1842673f396495e8
Revert your last commit, the quotes are needed to keep the space at the end.
Revert your last commit, the quotes are needed to keep the space at the end.
Are the quotes correct?
Actually, I think the quotes and the space are not needed.
I added the quotes because Android turns ": " into ":" without them.
The NP card shuffling is related to the Shuffle option in the Battle Config options.
If you enable that option and use the NP of the first Servant, it will shuffle the cards if there are 0 cards for the first servant.
The config option is translated as 无施放宝具从者的指令牌.
There's only one string without translation: p_thresholded_stage_counter.
This is the wikipedia article on thresholding, since it's hard to explain: https://zh.wikipedia.org/wiki/%E4%BA%8C%E5%80%BC%E5%8C%96
@MetLee Reminder
I am not good at image processing. I guess that when the switch on, FGA will use the binary image (not the RGB image or the grayscale image) to detect the stage counter, for reducing consumption and rapid response. Is it right?
I linked the Wiki page because you can reuse words from there.
The full explanation is: FGA normally takes screenshots of the stage counters and compares the images with each other. If they're similar, we're on the same stage. Otherwise, the stage changed.
During this comparison, the images are first turned to shades of gray. Then a complicated algorithm is used to calculate the similarity by comparing each pixel and calculating the difference.
The "thresholded stage counter" works a bit different: The old image is still turned gray, but the new one is turned into the whitest white and blackest black. Anything lighter than a certain gray tone is turned white, the rest is turned black. Then the usual algorithm is used to compare the old gray image with the new black and white image.
I can't tell you if it works better than the old method or not.
OK, I see. So it is just a feature which we don't know how well it works. This function only affects the new image and the old one is still gray scale.
I think that the user don't have to know how the feature works (but translator should figure it out), so I focus the translation on the binary image.