jackson-module-jsonSchema icon indicating copy to clipboard operation
jackson-module-jsonSchema copied to clipboard

Wrong schema generated

Open peterpivarnik opened this issue 1 year ago • 0 comments

Hello, I want to generate schema for carDto, which contains as attributes also four tireDto's. Here is exmaple of such dto's:

@Getter
@Setter
public class CarDto
{
  private String licencePlate;
  private String vin;
  private String brand;
  private String model;
  private TireDto tireFrontLeft;
  private TireDto tireFrontRight;
  private TireDto tireBackLeft;
  private TireDto tireBackRight;
}
@Getter
@Setter
public class TireDto
{
  private String tireBrand;
  private String tireModel;
  private String dimension;
  private String season;
}

Here is the test how I want to generate schema:

  @Test
  void shouldGenerateValidSchema() throws IOException {
    SimpleModule module = new SimpleModule();
    ObjectMapper objectMapper = new ObjectMapper();
    objectMapper.registerModule(module);

    ObjectSchema dtoSchema = (ObjectSchema) new JsonSchemaGenerator(objectMapper).generateSchema(CarDto.class);

    System.out.println(dtoSchema.getProperties());
  }

I would expect that all attributes of class TireDto (tireFrontLeft, tireFrontRight, tireBackLeft and tireBackRight) will be instances of the same schema. But it is not like that. First attribute tireFrontLeft is instance of ObjectSchema and all others (tireFrontRight, tireBackLeft and tireBackRight) are instances of ReferenceSchema. Besides that, only tireFrontLeft contains also properties of TireDto.

Here I'm also attaching screenshot from debugging. image

So is it a bug, or I'm missing some configuration?

peterpivarnik avatar May 30 '23 08:05 peterpivarnik