jackson-dataformats-binary icon indicating copy to clipboard operation
jackson-dataformats-binary copied to clipboard

InputData source not (yet?) supported for this format (Smile, CBOR)

Open henrik-lindqvist opened this issue 7 years ago • 5 comments

Seems the createParser method of SmileFactory and CBORFactory is lacking implementation for java.io.DataInput sources.

henrik-lindqvist avatar Sep 22 '16 04:09 henrik-lindqvist

Yes, this is correct. Due to time it took to add implementation for json backend, I had to postpone implementation for CBOR and Smile which would be the next likely cases (protobuf, alas, may be not supportable without external framing).

Would you be interested in using such input source if it was available? And if so, any preference order?

Note, too, that creating backend should be quite simple and mechanical. However, I don't think it is doable by refactoring just because byte access is on critical path: that is, addition of nextByte() (or whatever) abstraction would be performance problem. This based on json implementation experiences.

cowtowncoder avatar Sep 22 '16 05:09 cowtowncoder

No great importance. Glancing at the source, with little in-depth knowledge, i though it was a minor job, overriding a method. Simple workaround, using a DataInput to InputStream wrapper for now.

henrik-lindqvist avatar Sep 23 '16 02:09 henrik-lindqvist

Ok. Mostly asking since I hope to gauge interest in yet-to-add/complete features, and if there's demand for InputData implementation I would consider it for implementation. There are so many things to potentially work on that I prefer working on things that seem more likely to be used and useful. :)

cowtowncoder avatar Sep 23 '16 17:09 cowtowncoder

Focus on the more useful things! As said there's a simple workaround anyway.

henrik-lindqvist avatar Sep 23 '16 23:09 henrik-lindqvist

@henrik-lindqvist :)

cowtowncoder avatar Sep 24 '16 03:09 cowtowncoder