jackson-annotations icon indicating copy to clipboard operation
jackson-annotations copied to clipboard

Add @JsonWrapped (to complement @JsonUnwrapped)

Open lukens opened this issue 11 years ago • 16 comments

Re-rasing this issue from the old Jira bug tracker: https://jira.codehaus.org/browse/JACKSON-781

It was suggested this should be raised in the data bind project, but as it is an annotation, this seemed a better fit.

This is the original issue description:

@JsonUnwrapped allows people who want a more compressed JSON hierarchy than their POJO to affect the process, but there is no option for the reverse. I have a REST service producing unnecessary additional layers of abstraction that i would like to exclude from my Java POJOs rather than writing all sorts of unseemly wrapper classes.

I agree this would be a great feature to avoid unnecessary wrappers on the Java side when consuming JSON APIs.

I'd picture a new annotation that would take a form along the lines of:

@JsonWrapped("address")
@JsonProperty("house_number")
private String houseNumber;

or it could be an additional parameter of the @JsonProperty annotation:

@JsonProperty(value="house_number", wrapped="address")
private String houseNumber;

or, possibly, the value parameter of the @JsonProperty annotation could specify the object hierarchy:

@JsonProperty("address.house_number")
private String houseNumber;

This may introduce backwards compatibility issues, though, as it would mean this behaved differently than it currently does.

It would be good if it could also unwrap multiple levels, such as:

@JsonWrapped("contact_details.address")
@JsonProperty("house_number")
private String houseNumber;

Though, this would mean the value of the @JsonWrapped annotation was parsed differently than the value of the @JsonProperty annotation (as "contact_details.address" in the @JsonProperty annotation would refer to an object key named "contact_details.address").

lukens avatar Sep 11 '14 09:09 lukens

You are right in that annotation itself would be added here, but none of code handling it will be, which is why I think databind is actually better place for this. But that's fine; we can even just have 2 issues, one for annotation, one for handling, mostly just to have entries for release notes for both.

As to multiple levels, I thought about that, and if that was to be supposed, I don't think we can assume '.' can be used as separator, since it is a legal property name character. But changing this to allow sequence of ids is easy, like:

@JsonWrapped({ "contact_details", "address" })

and Java annotations also allow omitting arrays to just do single as well

@JsonWrapped("single")

cowtowncoder avatar Sep 11 '14 16:09 cowtowncoder

:+1:

codeallthethingz avatar Dec 04 '14 02:12 codeallthethingz

:+1:

geota avatar Jan 12 '15 20:01 geota

+1

asafdav2 avatar Mar 09 '15 16:03 asafdav2

+1. I'd love if this were added to @JsonProperty with the optional array syntax @cowtowncoder suggested:

@JsonProperty({"address", "housenumber"})

sadlerjw avatar Mar 19 '15 18:03 sadlerjw

This would save a lot of boilerplate. +1

mrolla avatar Mar 24 '15 10:03 mrolla

:+1:

natnan avatar Mar 25 '15 12:03 natnan

I would also like to see this feature. Is there a workaround for this? Especially in combination with mixins?

thomaseizinger avatar Apr 12 '15 11:04 thomaseizinger

Currently custom serialializer/deserializer would be the way to go. Or possibly converting serializer/deserializer using disposable wrapper classes.

cowtowncoder avatar Apr 13 '15 03:04 cowtowncoder

+1 for

@JsonWrapped({ "contact_details", "address" })

patrykorwat avatar Jun 16 '15 20:06 patrykorwat

+1

Redliver avatar Aug 11 '15 02:08 Redliver

+1

peruzzo avatar Nov 04 '15 20:11 peruzzo

+1

ghost avatar Dec 24 '15 11:12 ghost

+1

djechelon avatar Feb 01 '16 10:02 djechelon

Enough voting -- locking issue for now, hoping github will add something better than needing to add more +1 comments. :)

cowtowncoder avatar Feb 01 '16 15:02 cowtowncoder

Unlocking to allow use of reactions (use "thumbs up" to "vote"). Please no "+1" comments (content-containing comments welcome of course).

cowtowncoder avatar Feb 01 '21 23:02 cowtowncoder