StaxMate icon indicating copy to clipboard operation
StaxMate copied to clipboard

re #13, re #14

Open elbosso opened this issue 2 years ago • 2 comments

This is the code I added to achieve all things needed to write an xml editor that has a XPATH search that highlights all matching regions inside the text view as seen in #14 - I thought maybe it would be interesting to others also...

elbosso avatar Sep 12 '22 14:09 elbosso

First of all, thank you for this contribution.

I added some comments, but there are a couple of bigger questions I have...

First, I noticed there are no unit tests We would need something to verify that code actually works to basic degree. It would also show something about functionality added (which new things can be done).

Second: it would be good to a proper description of added functionality (it sounds like Location information will be available; and partial namespace lookup) on this PR and/or related issues you filed (#13 and #14). Most users do not go through actual diffs to code.

cowtowncoder avatar Sep 12 '22 17:09 cowtowncoder

added tests and needed resources with the last commit

elbosso avatar Sep 16 '22 12:09 elbosso