FastForward icon indicating copy to clipboard operation
FastForward copied to clipboard

Substitution in spanish now works (didn't before)

Open Adair-GA opened this issue 1 year ago • 2 comments

Fix(es):

Some substitutions didn't work in Spanish. I suspect they might not work in more languages, I made a quick python script that suggests that more than 500 entries would need updating. I think that it's possible to do this automatically, by replacing the "%" sign with a "$1 in every message which key doesn't contain "option" (as the options page ones need the "%" for input places and such), but I don't really want to make a possibly breaking change to so many languages. I'll upload the script I made to a gist for if someone want's to take a look at it.

  • [*] I made sure there are no unnecessary changes in the code;
  • [*] Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
  • [*] Tested on Firefox.

Adair-GA avatar Jan 10 '24 20:01 Adair-GA

Download the artifacts for this pull request:

github-actions[bot] avatar Jan 10 '24 20:01 github-actions[bot]

Link to python script It's really simple and it might work correctly but it might also break something xd

Adair-GA avatar Jan 10 '24 21:01 Adair-GA

Problem solved with other PR. FYI @Adair-GA

https://github.com/FastForwardTeam/FastForward/pull/1390

ramazansancar avatar May 11 '24 00:05 ramazansancar

Okay, thanks :)

Adair-GA avatar May 13 '24 08:05 Adair-GA