RogueSharp icon indicating copy to clipboard operation
RogueSharp copied to clipboard

Methods that return IEnumerable<T> should be consistent with yields

Open FaronBracy opened this issue 6 years ago • 0 comments

DijkstraShortestPath.PathTo method returns an IEnumerable and could yield return DirectedEdge. https://github.com/FaronBracy/RogueSharp/blob/master/RogueSharp/Algorithms/DijkstraShortestPath.cs#L130

Currently it does not, yet many other methods in the solution that return IEnumerable do. https://github.com/FaronBracy/RogueSharp/blob/master/RogueSharp/Map.cs#L293

Investigate which approach is better and be consistent within the project.

FaronBracy avatar Feb 02 '19 18:02 FaronBracy