react-native-google-places-autocomplete icon indicating copy to clipboard operation
react-native-google-places-autocomplete copied to clipboard

Published 20 hours ago • verified publisher icon FaridSafi

Surface non-200 request errors

Open localjo opened this issue 2 years ago • 1 comments

Currently, if a request to the Google Places API fails with a non-200 status code, there is no console warning, and the onFail callback is not called. This PR fixes that, so that the errors can be surfaced.

An example case is if requestUrl uses the Google API without a proxy, or if the proxy does not have allow-origin CORS headers, then the request fails with a 403, forbidden status. Currently, those cases fail silently, so this PR fixes that, allowing users to specify an error handler and surface the error.

localjo avatar Nov 04 '22 09:11 localjo

+1, would like the ability to pass an onFail prop that will be called if non-200 is returned! @FaridSafi

tylerlaskey avatar Jul 10 '24 23:07 tylerlaskey