react-native-google-places-autocomplete icon indicating copy to clipboard operation
react-native-google-places-autocomplete copied to clipboard

Feature: Display loader while loading results

Open C-Flatla opened this issue 4 years ago • 11 comments

What's in this PR?

This PR adds a listLoaderComponent prop to enable showing a loading component while results are loading

Quick summary of the changes you made.

  • Added a listLoaderComponent prop

Any necessary explanation of decisions you made

  • This will be passed as the listEmptyComponent to the FlatList while the requests are in flight
  • Defaults to not showing any loading indicator
  • This PR is very similar to https://github.com/FaridSafi/react-native-google-places-autocomplete/pull/720

Before

https://user-images.githubusercontent.com/5545625/120728953-37cba500-c49b-11eb-9e07-a8f6f1deabea.mov

After

https://user-images.githubusercontent.com/5545625/120728067-50d35680-c499-11eb-85e1-27cb0ca5b7f5.mov

C-Flatla avatar Jun 04 '21 00:06 C-Flatla

When is this going to be merged?

eyalabs avatar Jul 12 '21 09:07 eyalabs

@eyalabs 🤷 Still waiting for it to be reviewed

C-Flatla avatar Jul 15 '21 21:07 C-Flatla

@gruckion who can merge this?

eyalabs avatar Aug 22 '21 08:08 eyalabs

Still waiting for this feature

rick427 avatar Jul 26 '22 19:07 rick427

@v-x2 or @gruckion could we merge this, please? I've fixed the merge conflicts.

Sorry for the delay, I was on parental leave.

C-Flatla avatar Sep 06 '22 18:09 C-Flatla

Why isn't this being merged? Enable it with a flag and we can move on with it.

SaadBazaz avatar May 18 '23 10:05 SaadBazaz

please merge it 🙏

jbcrestot avatar May 31 '23 15:05 jbcrestot

Could we please merge this, this is really neat feature and we are having trouble outside of this component trying to accomplish the same.

wegethertravel avatar Jul 12 '23 19:07 wegethertravel

@FaridSafi could you kindly merge this?

wegethertravel avatar Jul 12 '23 19:07 wegethertravel

hello any one help me..

listLoaderComponent={() => { return <Text style={{backgroundColor: 'red'}}>loading...</Text>; }}

not working...

Parmar-Bansi avatar Sep 15 '23 06:09 Parmar-Bansi

closed by #909 ?

jbcrestot avatar Jul 18 '24 08:07 jbcrestot