react-native-gifted-listview icon indicating copy to clipboard operation
react-native-gifted-listview copied to clipboard

iOS autoPaginate ready for primetime

Open faceyspacey opened this issue 8 years ago • 1 comments

This builds upon what @realaboo did in https://github.com/FaridSafi/react-native-gifted-listview/pull/10, primarily solving the bug he pointed out where iOS fires multiple times on first load. Basically, I just fire a flag indicating whether the first load is complete and disable infinite scrolling until that point, and voila!

Also, there is some minor fixes in _renderPaginationView():

  • it wasn't even going to show since it relied on pagination === true and not also the `autoPaginate' prop. that's fixed.
  • I also guarantee standard pagination views won't shown when autoPaginate is set. I supposed if you toggled both on, you might still have some issues, but it's not a big deal. It should be pretty obvious when those "issues" arise to toggle the one you're not using off.

Lastly, I'd commit this into @realaboo's branch, but he did his work before various changes in the latest repo. So credit goes to him, but also know that this is already combined with the latest code. It should be good to go! Give it a whirl.

faceyspacey avatar Apr 02 '16 13:04 faceyspacey

This is great! Also +1 for changing autoPagination to infiniteScrolling.

realaboo avatar Apr 03 '16 02:04 realaboo