rules-framework icon indicating copy to clipboard operation
rules-framework copied to clipboard

Replace conditions collection with dictionary

Open luispfgarces opened this issue 5 months ago • 0 comments

Description

For performance reasons, this PR replaces the references:

  • IEnumerable<Condition<TCondition>> by IDictionary<TCondition, object>
  • IEnumerable<Condition<string>> by IDictionary<string, object>

[!WARNING] BREAKING CHANGE: conditions are no longer accepted via a collection of Condition and a dictionary is accepted instead. As such, all calls to MatchOneAsync(...), MatchAllAsync(...), and SearchAsync(...) will need adjustment to provide a dictionary of conditions alternatively.

Change checklist

  • [x] Code follows the code rules guidelines of this project
  • [x] Commit messages follow the commit rules of this project
  • [x] I have self-reviewed my changes before submitting this pull request
  • [x] I have covered new/changed code with new tests and/or adjusted existent ones
  • [ ] I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

luispfgarces avatar Sep 06 '24 17:09 luispfgarces