kafkaflow icon indicating copy to clipboard operation
kafkaflow copied to clipboard

Rework type name resolves to able to change the implementation

Open nazarii-piontko opened this issue 1 year ago • 0 comments

Description

  • Implemented a possibility to override the default implementation of IAsyncSchemaRegistryTypeNameResolver for Protobuf and Avro schemas.
  • Added TryAdd... methods to add service to the DI container if it is not there already. It is necessary to not override the customer-defined implementation of the name resolver.
  • Added interfaces IConfluentAvroTypeNameResolver and IConfluentProtobufTypeNameResolver to have the possibility to register different name resolvers for Avro and Protobuf schemas.

Fixes # (issue)

Make ConfluentProtobufTypeNameResolver more flexible on type name construction #404

How Has This Been Tested?

  • Added unit tests for the new ConfluentProtobufTypeNameResolver implementation.
  • Added unit tests for TryAdd... methods.
  • Manually tested with samples/KafkaFlow.Sample.SchemaRegistry.

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have added tests to cover my changes
  • [ ] I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

nazarii-piontko avatar Aug 18 '23 17:08 nazarii-piontko