kafkaflow icon indicating copy to clipboard operation
kafkaflow copied to clipboard

Published 20 hours ago • verified publisher icon Farfetch

Deduplicate topic declaration before trying to create them

Open kYann opened this issue 1 year ago • 4 comments

Description

Deduplicate topic list before sending it to AdminClient. Handle case where client call multiple CreateTopicIfNotExists with same topic name.

Fixes #382

How Has This Been Tested?

Tested on our solution

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have added tests to cover my changes
  • [ ] I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

kYann avatar Mar 16 '23 13:03 kYann

Sorry I thought I answered but did not. Yes I agree with your solution.

kYann avatar Jul 09 '23 20:07 kYann

Sorry I thought I answered but did not. Yes I agree with your solution.

@kYann are you available to review the PR applying that?

gsferreira avatar Jul 24 '23 13:07 gsferreira

Yes !

kYann avatar Jul 24 '23 13:07 kYann