DiscordPlugins icon indicating copy to clipboard operation
DiscordPlugins copied to clipboard

[Right Click Join] Some users do not have a `Join Call` option in the channel list.

Open Farcrada opened this issue 3 years ago • 2 comments

Describe the bug When the channel's limit is exceeded (i.e. more users than the limit has imposed are connected) Right Clicking users becomes a hit or miss, and only the amount of "allowed" (for a limit of 3 only 3 users out of the connected users) users will have the option this plugin provides.

To Reproduce Right click users in a voice channel that has exceeded the limit (this elongates to right clicking them everywhere else).

Expected behaviour Regardless of the channel limit; be able to right click users and join.

Screenshots n/a

Please complete the following information:

  • OS: W10 64bit
  • Plugin version: latest
  • Better Discord (BD) Version: latest

Additional context This is likely somewhere deeper than the plugin can easily reach and will require some research. So far getVoiceStatesForChannel only returns up to the limit of that channel (limit == 3? returns 3).

Farcrada avatar Jun 07 '21 11:06 Farcrada

This is interesting. Much as with most stores not everything on the planet is cached/loaded, as won't be the case here.

image This image leads me to believe there is a fetchChannel (or something of that nature) to update voice states or channels. Only problem now is how to reliably fetch channels and without spamming or angering the API. 🤔

Farcrada avatar Jun 07 '21 11:06 Farcrada

It is in fact not the plugin that has it wrong. The user that you are attempting to right click is not connected to that channel.

In my side by side testing I found out that they would show up in a channel and have only one instance represent that (the older session). The plugin would retrieve that user's current state but since it is bugged in the channel list it won't show a context item; meaning they are not actually in a/that voice channel which is represented by the retrieving of that user's current state.

This is mostly found on the bigger servers, with lots of users connecting and disconnecting to voice channels along with session age.

Farcrada avatar Jun 24 '21 16:06 Farcrada