Shimmy icon indicating copy to clipboard operation
Shimmy copied to clipboard

Fix DmLab tests

Open pseudo-rnd-thoughts opened this issue 2 years ago • 5 comments

Description

The CI hasn't been run for a while, just checking that everything still works

pseudo-rnd-thoughts avatar Feb 05 '24 00:02 pseudo-rnd-thoughts

@elliottower Do you know why the DM-Lab tests are not failing?

pseudo-rnd-thoughts avatar Feb 05 '24 01:02 pseudo-rnd-thoughts

@elliottower Do you know why the DM-Lab tests are not failing?

Sorry didn’t see this until now, but am not sure. Took a look and the error seems to be exiting with code 5 but no error message in the action, and pytest has only a warning listed. So it may just be a one off GitHub actions issue, not sure

elliottower avatar Feb 14 '24 15:02 elliottower

According to this stack overflow, error 5 occurs when no tests are run which matches the test case https://stackoverflow.com/questions/78061349/why-do-i-get-error-build-process-completed-with-exit-code-5-in-my-python-repo

pseudo-rnd-thoughts avatar Mar 07 '24 10:03 pseudo-rnd-thoughts

@elliottower there appears to be an issue importing dm-lab (https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336)

____________________ ERROR collecting tests/test_dm_lab.py _____________________
ImportError while importing test module '/usr/local/shimmy/tests/test_dm_lab.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_dm_lab.py:12: in <module>
    import deepmind_lab
../lib/python3.10/site-packages/deepmind_lab/__init__.py:[28](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:29): in <module>
    _deepmind_lab = imp.load_dynamic(
../lib/python3.10/imp.py:[34](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:35)3: in load_dynamic
    return _load(spec)
E   ImportError: /usr/local/lib/python3.10/site-packages/deepmind_lab/deepmind_lab.so: cannot open shared object file: No such file or directory

Not sure what the particular issue is, could you look at?

pseudo-rnd-thoughts avatar Mar 07 '24 11:03 pseudo-rnd-thoughts

@elliottower there appears to be an issue importing dm-lab (https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336)

____________________ ERROR collecting tests/test_dm_lab.py _____________________
ImportError while importing test module '/usr/local/shimmy/tests/test_dm_lab.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_dm_lab.py:12: in <module>
    import deepmind_lab
../lib/python3.10/site-packages/deepmind_lab/__init__.py:[28](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:29): in <module>
    _deepmind_lab = imp.load_dynamic(
../lib/python3.10/imp.py:[34](https://github.com/Farama-Foundation/Shimmy/actions/runs/8186519013/job/22385054336#step:4:35)3: in load_dynamic
    return _load(spec)
E   ImportError: /usr/local/lib/python3.10/site-packages/deepmind_lab/deepmind_lab.so: cannot open shared object file: No such file or directory

Not sure what the particular issue is, could you look at?

That’s super weird maybe we could try different versions of the dm lab package? That’s the only thing that I can imagine changed.

elliottower avatar Mar 13 '24 15:03 elliottower