PettingZoo icon indicating copy to clipboard operation
PettingZoo copied to clipboard

Run through release test and squash any bugs that can be squashed.

Open jjshoots opened this issue 2 years ago • 8 comments

jjshoots avatar May 01 '22 23:05 jjshoots

Hi @jjshoots, I'm new to this repo and the world of ML/AI (current student in GT's MSCS program) and want to contribute. Would I be able to take this issue? Also, can you explain what I need to do specifically? Thanks! - Trav

virgilt avatar May 02 '22 14:05 virgilt

Hi @virgilt, glad to have you onboard! You're free to take the issue under your wing if you feel like it.

Basically PettingZoo, as it stands, has seen a lot of development through the many release cycles of the libraries that it depends on. As a result of this, we're seeing more and more deprecation warnings, semantics warnings, etc. as time goes on in our tests.

The goal of this 'issue' is to pretty much run ~~./release_test.sh~~ pytest -v, and find any and all such warnings and then solve them within the codebase wherever possible and convenient to do so. Undoubtedly it's impossible to solve all of them, and many of them will require special attention, but the preliminary goal is to at least run through the surfacial level ones and handle those that are easy to solve.

Are you in the official RL discord group or PZ/Gym developers group btw? I'd encourage you to join and give me (@jat) a PM, and then we can move on from there. But should you choose not to, we accept just general PRs that address this issue as well, though integration and communication may be a bit delayed.

jjshoots avatar May 02 '22 17:05 jjshoots

@jjshoots @virgilt What is the status of this issue?

pseudo-rnd-thoughts avatar Aug 31 '22 12:08 pseudo-rnd-thoughts

@pseudo-rnd-thoughts No one's working on it atm.

jjshoots avatar Aug 31 '22 14:08 jjshoots

@jjshoots Is this issue still relevant?

WillDudley avatar Oct 13 '22 10:10 WillDudley

AFAIK this is always relevant, @reginald-mclean is on it if I'm not wrong.

jjshoots avatar Oct 13 '22 10:10 jjshoots

@reginald-mclean Do you have an update?

WillDudley avatar Oct 13 '22 10:10 WillDudley

Previously the number of warnings was 100k I believe, primarily through deprecation warnings. I was able to get this number < 1k I believe but now all of the warnings are the important ones that are difficult to understand

pseudo-rnd-thoughts avatar Oct 13 '22 10:10 pseudo-rnd-thoughts