Arcade-Learning-Environment icon indicating copy to clipboard operation
Arcade-Learning-Environment copied to clipboard
verified publisher icon Farama-Foundation

Change project src folder layout to use subfolder 'ale'

Open maichmueller opened this issue 1 year ago • 2 comments

Fixes #532

maichmueller avatar Jun 19 '24 11:06 maichmueller

@maichmueller I think the issue is related to NumPy 2.0, if you limit the numpy<2.0 in pyproject.toml this will probably fix

pseudo-rnd-thoughts avatar Jun 28 '24 16:06 pseudo-rnd-thoughts

Hi @pseudo-rnd-thoughts ,

Thanks for the hint! But this small numpy change now seems to cause the… vcpkg step to fail? I don’t quite understand the CI setup in how the steps interoperate; the changes in commits often don’t appear to me to correlate with the errors in the CI steps.

maichmueller avatar Jul 04 '24 13:07 maichmueller

@maichmueller There were several issues with the CI that took a while to fix. Could you merge with main and see if vcpkg is fix

pseudo-rnd-thoughts avatar Jul 23 '24 11:07 pseudo-rnd-thoughts

@pseudo-rnd-thoughts ,

thanks for those fixes! It seems the underlying CI issues have been resolved and all tests run successfully now. I am happy to bring this draft to full PR status then if you agree.

maichmueller avatar Jul 24 '24 12:07 maichmueller

@maichmueller Thanks for sorting this, I'm not confident enough to confirm implementation @JesseFarebro Could you look at this? I believe you should have the c++ expertise, if not please say

pseudo-rnd-thoughts avatar Jul 25 '24 04:07 pseudo-rnd-thoughts