FarManager icon indicating copy to clipboard operation
FarManager copied to clipboard

Editing or deleting a Filter does not update the Passive Panel

Open rohitab opened this issue 2 years ago • 2 comments

Far Manager version

3.0.6132.0 x64

OS version

10.0.22624.1616

Other software

No response

Steps to reproduce

  1. Create two directories Temp1 and Temp2
  2. In Temp1, create two empty files named 1.txt and 1.bat
  3. In Temp2, create two empty files named 2.txt and 2.bat
  4. Switch Active Panel to Temp1 directory
  5. Press Ctrl+I to open the Filters menu dialog
  6. Press Ins to create a new filter
  7. Enter TestFilter for the Name and *.txt for the Mask
  8. Press Enter to create the filter and close the Filter dialog
  9. Press + to add the filter to the Active Panel
  10. Press Esc to close the Filters menu dialog
  11. Note that the Active Panel shows a single file 1.txt; the second file is filtered out
  12. Press Tab to switch to the Temp2 directory in the Passive Panel
  13. Press Ctrl+I to open the Filters menu dialog
  14. Select the newly created TestFilter and press + to add the filter to the panel
  15. Press Esc to close the Filters menu dialog
  16. Note that the Active Panel shows a single file 2.txt; the second file is filtered out
  17. Also note that both panels show an asterisk character * indicating that they are being filtered
  18. Press Tab to switch back to the Temp1 directory
  19. Press Ctrl+I to open the Filters menu dialog
  20. Select the newly created TestFilter and press Del to delete the filter, and confirm the operation when prompted
  21. Note that both panels no longer show the asterisk character * indicating that they are not being filtered
  22. Press Esc to close the Filters menu dialog

Expected behavior

Both Temp1 and Temp2 directories should show all files.

Actual behavior

Temp1 directory shows all files, 1.txt and 1.bat. However, Temp2 directory, in the Passive Panel, only shows 2.txt. It does not show 2.bat. The Passive Panel, which has the directory Temp2 does not show the asterisk character *, indicating that it is not being filtered, even though it is in fact still using the deleted filter.

If you now press Tab to switch to the Passive Panel and the Temp2 directory, and then press Ctrl+R to Re-read the panel, all files will be visible.

Edit Filter

Please note that this issue is also present when editing a filter, instead of deleting it. If you edit the filter in Step 20 and change the Mask from *.txt to *.bat, you will notice that the Active Panel shows 1.bat, but the Passive Panel still shows 2.txt. Again, you need to press Tab, followed by Ctrl+R to Re-read the panel for it to hide 2.txt and show 2.bat.

rohitab avatar Apr 21 '23 03:04 rohitab

Perhaps the same bug was reported earlier https://bugs.farmanager.com/view.php?id=2898

johnd0e avatar Apr 21 '23 13:04 johnd0e

Thank you. Yes, it appears to be a similar issue, which was reported way back in 2015.

I always search GitHub before reporting an issue. The earlier bug report in Mantis, is in Russian, which is easy to translate once located, but hard to search for, since I don't speak Russian. My apologies.

This ticket does include additional information regarding the issue with editing a Filter, so I will leave it to the project maintainers to decide what to do with this ticket.

rohitab avatar Apr 22 '23 01:04 rohitab