Fanwang Meng

Results 84 comments of Fanwang Meng

Looks like a good feature to have. Please go ahead and make a pull request. Can you tag me when you are done? Thank you for making our package grow!...

Can you confirm that [6112464](https://github.com/theochem/procrustes/pull/186/commits/6112464441fedc19374c3c16e6355764a1858abe) is doing the right fix? The original documentation has a problem of equation rendering. Thank you. @banrovegrie

> Btw, what is this coverage report? `CodeCov` provides a nice way of visualizing the testing coverage of the pull request and more details can be found at https://about.codecov.io/.

> @FanwangM lets keep this PR open for the documentation errors we might encounter while implementing the last algorithm as well. I guess we can keep rebasing this commits over...

I don't think the method proposed in this paper is related to #42 and #16. They provided an alternative way to solve rotational Procrustes problem 2D and 3D without doing...

> It's weird how the issue doesn't exist at all for python3.8+ as well as python3.6-. True. I think it's Windows OS related only as I have tested for many...

I have tested it again on a windows machine with the same working environment (Python 3.7.9 and the same numpy and scipy version) and it works. Also, the current running...

What's the time difference between us now (your current location and Toronto)? @banrovegrie

> @FanwangM should we merge it too? Let's wait for a while. I am doing more investigation. The way you proposed works in a compromising way, but I would like...