django-tagging icon indicating copy to clipboard operation
django-tagging copied to clipboard

Add support for Django4

Open bartsanchez opened this issue 3 years ago • 9 comments

bartsanchez avatar Dec 12 '21 17:12 bartsanchez

Is this project still alive? Having Django4 support would be great.

thomass4t avatar May 26 '22 13:05 thomass4t

??

satels avatar Oct 25 '22 08:10 satels

Any updates?

N1K1TAS95 avatar Dec 31 '22 10:12 N1K1TAS95

We use the patches from this PR also within Debian to keep django-tagging within the archive usable. Since a few days after the transition of Python 3.11 as default version the CI is reporting now failing tests.

...
  File "/usr/lib/python3/dist-packages/django/urls/resolvers.py", line 196, in _compile
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: "^(?P<tag>[^/]+(?u))/$" is not a valid regular expression: global flags not at the start of the expression at position 14
...

https://ci.debian.net/data/autopkgtest/unstable/amd64/p/python-django-tagging/29984367/log.gz

I'm not a expert for regular expressions, but to me it looks like the used regexp would need an update and adjustment. Someone of the involved people here can come up with a suggested modification? I'm happy to test that.

tijuca avatar Jan 15 '23 08:01 tijuca

The ?u is a flag to switch to Unicode matching. Placing it in the middle of the regex string was removed as it is ambigious. Maybe it is sufficient to place (?u) at the beginning of the string (before the ^). I would suggest to create a new issue because it has more to do with the python upgrade.

thomass4t avatar Jan 15 '23 12:01 thomass4t

@Fantomas42 looks like many people/projects uses this django-app including the widelands website which i maintain. Some reaction would be nice :smiley:

frankystone avatar Feb 07 '23 16:02 frankystone

Issues has been disabled on this repository. Feels like this project needs a new maintainer. https://github.com/Fantomas42 has had no github activity for two years, since late 2020. However good news is there are two other maintainers with PyPI access according to https://pypi.org/project/django-tagging/ , so we could arrange for a repo fork to take over maintenance, without needing a project rename also. @brosner and @insin , are one of you able to help ?

jayvdb avatar Mar 06 '23 00:03 jayvdb

Hi @Fantomas42 , @brosner and @insin 👋🏼

Would you have time to consider making a release to support the latest Django version? Please let me know if I can help in any way.

Many thanks!

CuriousLearner avatar Apr 12 '24 00:04 CuriousLearner

I've made a new release of this library with django 4.2 support here: https://github.com/ccnmtl/django-tagging/releases/tag/0.5.1

It's not on pypi but you can use this wheel file.

nikolas avatar Apr 15 '24 18:04 nikolas