django-blog-zinnia icon indicating copy to clipboard operation
django-blog-zinnia copied to clipboard

All tests passing

Open kbhalerao opened this issue 4 years ago • 1 comments

What is the purpose of your pull request?

  • [x] Bug fix
  • [ ] New feature

Proposed changes

Modified the branch to make the following changes:

  1. Reconciled language symbols to match Django 3.0's specification (https://github.com/django/django/blob/master/django/conf/global_settings.py)
  2. Replaced {% load staticfiles %} with {% load static %} (https://docs.djangoproject.com/en/dev/releases/3.0/#features-removed-in-3-0, deprecated in 2.1)
  3. Fixed a couple tests testing for the visbility and existence of an Entry based on a timestamp - the test dates were not appropriate for the tests, and
  4. Fixed a test in tests_views, where only 3 queries were being used instead of 5.

Warning

Before submitting a pull request make sure you have:

  • [x] Read the guidelines for contributing.
  • [ ] Wrote some tests.
  • [x] Respected the PEP 8.

kbhalerao avatar Apr 06 '20 20:04 kbhalerao

Hi, i believe you also should rename the locale folders (in zinnia/locale/) to reflect your changes of language symbols.

Eyap53 avatar Sep 25 '20 15:09 Eyap53